Use None/Include to ensure items are included in generated nupkg files. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I was certain these items were present in the build, so I did some digging and this is super weird. It's an oddity in the way NuGet packs items when multitargeting. The issue appears to be that NuGet collects the Switching these from |
|
The failing test appears to be an existing race that is hopefully fixed by #178 I'll land a couple other fixes then publish a new preview to nuget.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is a straightforward one - I think the latest dependency fixes regressed the
T4.BuildToolspackages as the targets/props files weren't included in the nupkg.Have run
dotnet buildlocally and can confirm these changes ensure the props/targets are included.This should address #176
Thanks!